-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "servers" support to Ruby API client #1280
Conversation
I did a quick look over this PR, and it looks good. It's not clear to me where the content-type fix in the generated output comes from. I'm assuming the sample either wasn't generated since the fix, or the addition of the new working servers implementation makes content-types available as expected. |
@wing328 thanks for the review. The additional content-type is due to the use of OAS v3 spec (which supports multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
* update ruby samples with OAS3 spec * add server support to ruby api client * minor format change * minor format fix, skip form models * better exception and add test for invaid value * remove exception test code
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.Description of the PR
cc @cliffano (2017/07) @zlx (2017/09)
cc @OpenAPITools/generator-core-team (https://github.com/OpenAPITools/openapi-generator/pull/1280/files#diff-9f39023184e570db9adc3829e67cb2e0R171)