Skip to content

Conversation

@evanjmg
Copy link
Contributor

@evanjmg evanjmg commented Jun 27, 2022

Prepare build is required in order to publish

PR checklist

  • [X ] Read the contribution guidelines.
  • [ X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [X ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.

Prepare build is required in order to publish
@fredericrous
Copy link

fredericrous commented Jun 27, 2022

without the "prepare" step, the package that is published does not contain the built artefact. we are just publishing the sources.

The other generators already implement the prepare step
example:

@macjohnny
Copy link
Member

can you please re-generate the samples?

@wing328
Copy link
Member

wing328 commented Aug 5, 2025

merged via #21684

thanks for the pr

@wing328 wing328 closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants