[Lua] Remove outdated comment #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Oct 21, 2018
| @@ -18,6 +18,7 @@ local basexx = require "basexx" | |||
| -- model import | |||
| local petstore_api_response = require "petstore.model.api_response" | |||
| local petstore_pet = require "petstore.model.pet" | |||
| local petstore_pet = require "petstore.model.pet" | |||
There was a problem hiding this comment.
This seems to be an error.
There was a problem hiding this comment.
@daurnimator yup, saw that too. Will fix that with another PR (the issue is not caused by this PR)
There was a problem hiding this comment.
UPDATE: I've filed
#1414 to fix the issue (duplicated imports)
| @@ -17,6 +17,7 @@ local basexx = require "basexx" | |||
|
|
|||
| -- model import | |||
| local petstore_order = require "petstore.model.order" | |||
| local petstore_order = require "petstore.model.order" | |||
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
A PR to clean up outdated comment in Lua codes:
cc @daurnimator