Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt-client] Add support for AnyType objects #12642

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

danielrenninghoff
Copy link
Contributor

Fix #12641

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

The cpp-qt-client generator generates invalid code when the OpenAPI document contains AnyType objects (example: type: {}).
I have replaced AnyType with QJsonValue, so that the correct type can be manually unpacked later.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 25, 2022

Local tests compiled without issues. Thanks for the enhancement.

@wing328 wing328 merged commit c1b8780 into OpenAPITools:master Jun 25, 2022
@danielrenninghoff danielrenninghoff deleted the cpp-qt-fix-anytype branch June 27, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [cpp-qt-client] No support for AnyType objects
2 participants