[Rust] Client library choice between hyper and reqwest #1258
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/bin/sh | ||
|
|
||
| SCRIPT="$0" | ||
| echo "# START SCRIPT: $SCRIPT" | ||
|
|
||
| while [ -h "$SCRIPT" ] ; do | ||
| ls=$(ls -ld "$SCRIPT") | ||
| link=$(expr "$ls" : '.*-> \(.*\)$') | ||
| if expr "$link" : '/.*' > /dev/null; then | ||
| SCRIPT="$link" | ||
| else | ||
| SCRIPT=$(dirname "$SCRIPT")/"$link" | ||
| fi | ||
| done | ||
|
|
||
| if [ ! -d "${APP_DIR}" ]; then | ||
| APP_DIR=$(dirname "$SCRIPT")/.. | ||
| APP_DIR=$(cd "${APP_DIR}"; pwd) | ||
| fi | ||
|
|
||
| executable="./modules/openapi-generator-cli/target/openapi-generator-cli.jar" | ||
|
|
||
| if [ ! -f "$executable" ] | ||
| then | ||
| mvn -B clean package | ||
| fi | ||
|
|
||
| # if you've executed sbt assembly previously it will use that instead. | ||
| export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties" | ||
| ags="generate -t modules/openapi-generator/src/main/resources/rust -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -g rust -o samples/client/petstore/rust-reqwest -DpackageName=petstore_client --library=reqwest $@" | ||
|
|
||
| java ${JAVA_OPTS} -jar ${executable} ${ags} | ||
|
There was a problem hiding this comment. Why have the rust-reqwest sample generation in a separate script? Could you not extend the rust sample generation to do both, reducing the risk that someone will do one and forget to do the other? There was a problem hiding this comment. I don't have a particular reason. I will merge both scripts. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,21 @@ version = "{{{packageVersion}}}" | |
| authors = ["OpenAPI Generator team and contributors"] | ||
|
|
||
| [dependencies] | ||
| serde = "^1.0" | ||
| serde_derive = "^1.0" | ||
| serde_json = "^1.0" | ||
| url = "1.5" | ||
| {{#hyper}} | ||
| hyper = "~0.11" | ||
| serde_yaml = "0.7" | ||
| base64 = "~0.7.0" | ||
| futures = "0.1.23" | ||
| {{/hyper}} | ||
| {{#reqwest}} | ||
| reqwest = "~0.9" | ||
| {{/reqwest}} | ||
|
|
||
| [dev-dependencies] | ||
| {{#hyper}} | ||
| tokio-core = "*" | ||
| {{/hyper}} | ||
|
There was a problem hiding this comment. My highest-level question - why make the decision at codegen time rather than at compile time? You could presumably achieve the same effect with Rust features. I'm not saying you're wrong - merely curious as to why you chose as you did. There was a problem hiding this comment. I don't have a good reason for that. I am a beginner in Rust development and learning. I don't know what purpose this dev lib deserves. Since I could generate my project without it in the Cargo file, I dropped it, simply to keep the file as tiny as possible. If you think it is a mistake, I can put it back. There was a problem hiding this comment. I probably misunderstood your question (I thought it was about For the whole library choice, the main reason is that since I'm learning Rust, I don't know how to use it yet. Another reason whould be that There was a problem hiding this comment. That seems reasonable. I could well imagine that trying to have both in the same crate could cause problems if they ever had incompatible dependencies. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is back-compatible. As such, I would suggest creating this against the branch for the next major release - 4.0.x, I believe. See https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "library" modification is optional. If no library is chosen for generation, Hyper remains the default library. I may be wrong, but I think it is backward compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
hyperis the default, the change should be backward-compatible.If
reqwestis the default, the change should target 3.4.x branch as it's a breaking change with fallbacks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From
RustClientCodegen.java: