-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of boolean options in the Maven plugin #1252
Better handling of boolean options in the Maven plugin #1252
Conversation
Used commons-configuration2 for org.apache.commons.configuration2.PropertiesConfiguration. It makes the configuration easier to read amongst other benefits
@@ -52,6 +52,11 @@ | |||
<!-- <version>4.12</version> --> | |||
<scope>test</scope> | |||
</dependency> | |||
<dependency> | |||
<groupId>org.apache.commons</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use spaces instead of tabs
now fix across all generators
To fix #1164 cc @OpenAPITools/generator-core-team |
@@ -608,4 +610,24 @@ private void addCompileSourceRootIfConfigured() { | |||
} | |||
} | |||
} | |||
|
|||
private void adjustAdditionalProperties(final CodegenConfig config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raghuraman1 please add a Java docstring explaining what this function does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
@raghuraman1 thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832 |
* saving the fixes. Used commons-configuration2 for org.apache.commons.configuration2.PropertiesConfiguration. It makes the configuration easier to read amongst other benefits * removing tabs * updating and simplifying based on sugegstion from William. This should now fix across all generators * upgraded pom * added some javadocs for the new method
This contains fixes for the maven plugin. It causes the conversion to booleans of the additional properties