Better handling of boolean options in the Maven plugin #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used commons-configuration2 for org.apache.commons.configuration2.PropertiesConfiguration. It makes the configuration easier to read amongst other benefits
wing328
reviewed
Oct 16, 2018
| @@ -52,6 +52,11 @@ | |||
| <!-- <version>4.12</version> --> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
There was a problem hiding this comment.
Please use spaces instead of tabs
now fix across all generators
|
To fix #1164 cc @OpenAPITools/generator-core-team |
wing328
reviewed
Oct 18, 2018
| @@ -608,4 +610,24 @@ private void addCompileSourceRootIfConfigured() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private void adjustAdditionalProperties(final CodegenConfig config) { | |||
There was a problem hiding this comment.
@raghuraman1 please add a Java docstring explaining what this function does.
wing328
changed the title
|
@raghuraman1 thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* saving the fixes. Used commons-configuration2 for org.apache.commons.configuration2.PropertiesConfiguration. It makes the configuration easier to read amongst other benefits * removing tabs * updating and simplifying based on sugegstion from William. This should now fix across all generators * upgraded pom * added some javadocs for the new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains fixes for the maven plugin. It causes the conversion to booleans of the additional properties