Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid elm code for paths containing UUIDs #12506

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

mawis
Copy link
Contributor

@mawis mawis commented Jun 1, 2022

Fixes #12504

This fixes a problem in the template, that generates the function used to serialize the values of elm types to a string, that can be used within a query path.

For strings the function used for conversion is identity and for UUIDs then have to be converted to a string using Uuid.toString. The problem with the existing template is, that it adds both functions to the generated code. In case that we have a UUID we should only convert it to a string using Uuid.toString. The call to identity is superfluous and syntactically incorrect as well.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@eriktim

@eriktim eriktim self-assigned this Jun 1, 2022
@eriktim
Copy link
Contributor

eriktim commented Jun 1, 2022

Thanks!

@eriktim eriktim merged commit bcc77d4 into OpenAPITools:master Jun 1, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jul 2, 2022
@wing328 wing328 changed the title Fix for #12504: invalid elm code for paths containing UUIDs Fix invalid elm code for paths containing UUIDs Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [elm] UUIDs in path parameters generate invalid code
3 participants