-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): allow more granular Rust integer types and cleaned up clippy warnings #12479
Conversation
LGTM. Thanks for the enhancement. |
Sample up to date test failed in CI for this PR |
I am fixing it in: |
@@ -414,7 +456,8 @@ public String toVarName(String name) { | |||
|
|||
@Override | |||
public String toParamName(String name) { | |||
return toVarName(name); | |||
// $ref appears to be all uppercase which is contrary to rustfmt practice so lowercase parameters | |||
return toVarName(name.toLowerCase(Locale.ROOT)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This result in change of variable name (e.g. pet_id => petid): https://github.com/OpenAPITools/openapi-generator/pull/12817/files
I'll file a PR to fix it by remove https://github.com/OpenAPITools/openapi-generator/pull/12479/files#diff-8daa2cc862ff0a63dd72dac551951b1bb07675e3cc0609a6dea55d2e85492520R440 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #12820
Thanks @spacether |
minimum
andmaximum
are both setfalse
minimum
is defined and non-negativefalse
$ref
was being upper cased@frol
@farcaller
@richardwhiuk
@paladinzh
PR checklist
master
(6.0.1) (patch release),6.1.x
(breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)