Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart][Client] Support parsing DateTime #12433

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Conversation

kalymero
Copy link
Contributor

I've got an issue while parsing an Array of Strings in date-time format

        content:
            application/json:
              schema:
                type: array
                items:
                  type: string
                  format: date-time

which the generator translates into a List<DateTime>.
When the List is unwrapped and then it tries to _deserialize the DateTime it does not find any suitable parser.

This just fixes it

@ahmednfwela

PR checklist

  • [v] Read the contribution guidelines.
  • [v] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

I've got issue in parsing an Array of Strings in datetime format, which the generator translates into a List<DateTime>.

This just fixes it
@kuhnroyal
Copy link
Contributor

cc @agilob

@wing328
Copy link
Member

wing328 commented Jun 4, 2022

Samples updated via b39a1f8

@wing328 wing328 merged commit 5b44aaf into OpenAPITools:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants