[html2] added recursion for nested objects #12428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as the code is in JS (though for documentation generation)(html2) |
|
@0x7162 thanks for the PR. Let's give it a try. |
wing328
changed the title
|
FYI. samples updated via 0296380 |
6 tasks
kas1337
reviewed
Jul 12, 2022
| Object.keys(schema.properties).forEach( (item) => { | ||
| if (schema.properties[item].$ref != null) { | ||
| schema.properties[item] = defsParser.$refs.get(schema.properties[item].$ref); | ||
| } |
There was a problem hiding this comment.
@kas1337 thanks for catching the issue. Can you please file a PR with the suggested fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added recursive check for the references ($ref)
Now we should support nested objects.
[x ] Read the contribution guidelines.
[ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
[ x] Run the following to build the project and update samples:
./mvnw clean package
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
[x ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
To fix #9923