[General][CI] fix gradle build error on java9+ #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wing328 @jimschubert @cbornet @jaz-ah @ackintosh @JFCote @jmini |
|
@fujigon thanks for the fix. (I was looking into the issue as reported by Shippable last night but couldn't find a solution and was planning to roll back to openjdk8 for the time being) cc @jimschubert |
|
Looking this over, seems to be a miss from the recent change that bumped the gradle version from the release candidate. If it passes Shippable, I think it's good to merge. |
wing328
approved these changes
Oct 15, 2018
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
This patch fixes shippable CI failures due to
[ERROR] Failed to execute goal org.fortasoft:gradle-maven-plugin:1.0.8:invoke (default) on project openapi-generator-gradle-plugin-mvn-wrapper: Execution default of goal org.fortasoft:gradle-maven-plugin:1.0.8:invoke failed: Could not determine java version from '9.0.4'. -> [Help 1]The problem is that
org.fortasoft:gradle-maven-pluginsettings didn't suport java9+.Thanks to LendingClub/gradle-maven-plugin#39, I added settings to pom and it works on my environment (windows10, java10, and git bash).