Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csharp] Added constructor without parameter for C# template #1234

Merged
merged 2 commits into from
Oct 23, 2018
Merged

[csharp] Added constructor without parameter for C# template #1234

merged 2 commits into from
Oct 23, 2018

Conversation

Rizzen
Copy link
Contributor

@Rizzen Rizzen commented Oct 13, 2018 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Same with swagger-api/swagger-codegen#8775

/cc @mandrean

@Rizzen Rizzen changed the title Ctor without parameters [csharp] Added constructor without parameter for C# template Oct 13, 2018
@wing328 wing328 modified the milestones: 3.3.1, 3.3.2 Oct 14, 2018
@wing328 wing328 closed this Oct 23, 2018
@wing328 wing328 reopened this Oct 23, 2018
@wing328
Copy link
Member

wing328 commented Oct 23, 2018

I've updated the C# samples via 8455dfe and the test passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/19720983

@wing328 wing328 merged commit 8455dfe into OpenAPITools:master Oct 23, 2018
@wing328
Copy link
Member

wing328 commented Oct 23, 2018

@Rizzen the PR has been merged into master. Thanks for your contribution.

Please also note that we've an ongoing work/PR to refactor the C# client: #737

Please review and let us know if you've any feedback.

@wing328
Copy link
Member

wing328 commented Oct 23, 2018

cc @jimschubert

@wing328
Copy link
Member

wing328 commented Oct 31, 2018

@Rizzen thanks again for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832

@Cardeznet Cardeznet mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: C-Sharp Enhancement: General
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rizzen @wing328