Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micronaut] Improvements for Server and Client #12297

Merged
merged 10 commits into from
May 18, 2022

Conversation

andriy-dmytruk
Copy link
Contributor

@andriy-dmytruk andriy-dmytruk commented May 5, 2022

This PR includes multiple improvements:

Application name parameter

Added applicationName parameter that will also be used to distinguish base-path for different clients allowing multiple clients to be used in one application. Based on #11150.

Swagger annotations parameter

Changed the swagger annotations version to swagger2 (io.swagger.core.v3:swagger-annotations). The version can be configured using the generateSwaggerAnnotations option that supports values true (equivalent to swagger2), false, swagger1, swagger2. By default no annotations are generated for client and swagger2 for server. This supports what is requested in #12223 (with just supplying the value false).

Operations generated only for first tag

Added option to generate operations only for first tag. The issue is described in detail in #12224. The default behavior is to generate operation for each tag, so for definition

paths:
  /configureProfile:
    get:
      operationId: configureProfile
      # ...
      tags: [users, management]

the operation configureProfile will be repeated twice (once in Users and once in Management). This can be avoided by setting the generateOperationOnlyForFirstTag=true. By default it is set to true for server and false for client.

Sample, Docs generation, and tests

Ran:

./mvnw clean package
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
./bin/meta-codegen.sh

Tested the generation locally.

@wing328
@mshannongit

Java technical committee:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@wing328 wing328 merged commit 0ad970f into OpenAPITools:master May 18, 2022
@andriy-dmytruk
Copy link
Contributor Author

@wing328 Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants