Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of version in Rust client #12284

Merged
merged 1 commit into from
May 1, 2022
Merged

Better handling of version in Rust client #12284

merged 1 commit into from
May 1, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 1, 2022

Fix version with leading v in rust client.

It does not cover all edge cases though so we may need to improve it over time.

Tested locally to confirm the fix. Will add a test later when revising the spec with more test cases.

Another way is to set the packageVersion directly via an option.

To fix #12271

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

@wing328 wing328 added this to the 6.0.0 milestone May 1, 2022
@wing328 wing328 changed the title Fix version with in Rust client Fix version in Rust client May 1, 2022
@wing328 wing328 changed the title Fix version in Rust client Better handling of version in Rust client May 1, 2022
@wing328 wing328 merged commit 8dc6783 into master May 1, 2022
@wing328 wing328 deleted the rust-version-fix branch May 1, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust: unexpected character 'v' while parsing major version number for key package.version
1 participant