Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Kotlin-client] Handling default values of parameters #12255

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

sjoblomj
Copy link
Contributor

@sjoblomj sjoblomj commented Apr 27, 2022

Resolves #10865

Different Kotlin clients currently handle default values of parameters differently; some ignore them, some use the default value. Some also generate invalid Kotlin code, such as @Header("hn1") hn1: java.math.BigDecimal = 71.0 (Double cannot be assigned to BigDecimal).

This PR attempts to make the default values of parameters consistent and without invalid code. It also tidies up the generated comments a little, which unfortunately leads to a lot of changed sample files.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328

@sjoblomj sjoblomj force-pushed the kotlin_client_default_values branch from 1ec7179 to a7883c9 Compare April 27, 2022 09:34
@sjoblomj sjoblomj marked this pull request as draft April 27, 2022 09:49
@sjoblomj sjoblomj force-pushed the kotlin_client_default_values branch from 782b026 to c7955e8 Compare April 27, 2022 10:17
@sjoblomj sjoblomj force-pushed the kotlin_client_default_values branch from c7955e8 to f356369 Compare April 27, 2022 16:17
@sjoblomj sjoblomj marked this pull request as ready for review April 27, 2022 16:27
@4brunu 4brunu merged commit 8950a9a into OpenAPITools:master Apr 29, 2022
@4brunu
Copy link
Contributor

4brunu commented Apr 29, 2022

@sjoblomj Hi, thanks for taking the time to contribute to this project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] Default value should be generated in query param using Retrofit2
3 participants