-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export_generator shell script on Linux #1223
Conversation
re-run |
@fujigon thanks for the PR. Reviewing... |
@fujigon I tried to trigger a build failure via 8d82fc6 but the build still passed: https://circleci.com/gh/OpenAPITools/openapi-generator/2853. Still investigating why... |
I've a fix and https://circleci.com/gh/OpenAPITools/openapi-generator/2870#tests/containers/2 reported failure, which is the expected behaviour. |
@wing328 @fujigon I was reviewing this, but I couldn't understand how the change in this PR had any difference in sh, since the markdown outputs resulted in the same generator name outputs (only difference was the added generator properties). I think the bash syntax could be cleaned up a little more, but I wanted to understand the error that was being solved. Was the problem perhaps a I was testing on the |
Sorry, I missed the |
thanks for the review and merging! |
@fujigon thanks for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577 |
* fix export_generator shell script * fix script with bash * use bash instead of sh
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.4.x
,4.0.x
. Default:master
.Description of the PR
./bin/utils/export_docs_generators.sh
(and its depending./bin/utils/export_generators.sh
) has string pattern bug.