-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin-spring] Adding DocumentationProvider and SwaggerUI #12184
[kotlin-spring] Adding DocumentationProvider and SwaggerUI #12184
Conversation
d7ddabc
to
a9ff4e1
Compare
6894893
to
8697f7b
Compare
2b5f57e
to
f137088
Compare
b63ec85
to
684b0a1
Compare
684b0a1
to
0a7344f
Compare
0a7344f
to
cb10002
Compare
cb10002
to
17dbaac
Compare
17dbaac
to
16bd549
Compare
@sjoblomj Thanks for your effort - I'll try provide more detailed feedback in the next days. |
LGTM. Thanks for the PR 👍 |
@cachescrubber oops... sorry didn't see your comment earlier. Let us know your feedback and we'll file separate PRs instead 🙏 |
I've made a PR to update dependencies here: #12281 I'll take a look at #12220 and try to make a separate PR for it when I have time 👍 |
Since you have used hardcoded the content type as schema in for example This also is/was an issue in the |
This is my Kotlin Spring implementation of @cachescrubber's excellent work in #11258 and #11531.
A user can now select a Documentation Provider (None, Source, Springfox, Springdoc), an Annotation Library (None, Swagger1, Swagger2) and whether to use Swagger UI.
Please note that this removes the
swaggerAnnotations
option that previously existed! Considering this, it is probably a good idea to include this PR in version 6.0.0 with breaking changes, if the PR is deemed to be useful and of sufficient quality.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
@cachescrubber @wing328 @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m