Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micronaut] remove duplicate JsonTypeName #12029

Merged

Conversation

pbthorste
Copy link
Contributor

In some cases, where the openapi file uses a discriminator, @JsonTypeName will appear twice - causing an error. This PR removes it from typeInfoAnnotation.mustache since it will always be included in pojo.mustache

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    Java technical committee (not sure if required):
    @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@wing328
Copy link
Member

wing328 commented Apr 2, 2022

@pbthorste thanks for the PR. I'm able to repeat the issue and confirmed the fix:

@@ -49,7 +49,6 @@ import javax.annotation.Generated;
   @JsonSubTypes.Type(value = Whale.class, name = "whale"),
   @JsonSubTypes.Type(value = Zebra.class, name = "zebra"),
 })
-@JsonTypeName("mammal")

as @JsonTypeName("mammal") already present already in the code.

@wing328
Copy link
Member

wing328 commented Apr 2, 2022

cc @andriy-dmytruk

@wing328 wing328 added this to the 6.0.0 milestone Apr 2, 2022
@wing328 wing328 merged commit 05290fa into OpenAPITools:master Apr 2, 2022
@pbthorste pbthorste deleted the feature/fix-duplicate-jsontypename branch April 4, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants