Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Fix form serialization typo from #11225 #11990

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

ybelenko
Copy link
Contributor

Should fix failed tests from #11225. I missed that one, sorry, PR was really huge.

@nadar

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 29, 2022

@ybelenko that's ok bro. Thanks for the quick fix.

[INFO] --- exec-maven-plugin:1.2.1:exec (bundle-test) @ PhpPetstoreOAS3Tests ---
PHPUnit 9.5.19 #StandWithUkraine

..............* Closing connection 0
.* Closing connection 0
................................................  63 / 124 ( 50%)
.............................................................   124 / 124 (100%)

Time: 00:01.813, Memory: 12.00 MB

OK (124 tests, 274 assertions)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.199 s
[INFO] Finished at: 2022-03-29T13:05:38+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 9ce3d2b into OpenAPITools:master Mar 29, 2022
@ybelenko ybelenko deleted the 11225_patch branch March 29, 2022 12:31
@wing328 wing328 added this to the 6.0.0 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants