Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum value without escaping HTML special characters #1193

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 8, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix Dart, Scala tempaltes using {{{value}}} and {{{name}}} to avoid HTML special characters being escaped.

@wing328
Copy link
Member Author

wing328 commented Oct 8, 2018

cc
Dart: @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)
Scala: @clasnake (2017/07) @jimschubert (2017/09) @shijinkui (2018/01) @ramzimaalej (2018/03)

@ghost
Copy link

ghost commented Oct 8, 2018

LGTM

@wing328 wing328 merged commit 22049db into master Oct 8, 2018
@wing328 wing328 deleted the fix_enum branch October 8, 2018 23:08
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant