Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flask] Upgrade to flask connexion 2.0.0rc3 #1192

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Oct 7, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Not yet optimal but a little better than using a "git commit" version

@cbornet
Copy link
Member Author

cbornet commented Oct 7, 2018

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 5ac33a4 into OpenAPITools:master Oct 8, 2018
@twosigmajab
Copy link

twosigmajab commented Oct 24, 2018

I just saw this PR (nice!) and noticed that the setup.py still doesn't specify any Connexion version:

Shouldn't that specify this same version?

@cbornet cbornet deleted the flask-2.0.0rc3 branch October 24, 2018 16:11
@cbornet
Copy link
Member Author

cbornet commented Oct 24, 2018

Indeed !

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants