Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Update spring-cloud generator to use openfeign #1191

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Oct 7, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Feign is now openfeign. We already made the change for the Java gen. This is the same for the spring-cloud gen.

@cbornet cbornet changed the title Update spring-cloud generator to use openfeign [Spring] Update spring-cloud generator to use openfeign Oct 7, 2018
@cbornet
Copy link
Member Author

cbornet commented Oct 7, 2018

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works fine as expected

@wing328 wing328 merged commit 34409bc into OpenAPITools:master Oct 14, 2018
@cbornet cbornet deleted the spring-cloud-openfeign branch October 14, 2018 07:05
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants