Add JDK 9 support #1188
Merged
Add JDK 9 support #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimschubert I've updated the gradle version as well: https://github.com/OpenAPITools/openapi-generator/pull/1188/files#diff-100635b319e4bc29ba29da64405bcea4R57 Let me know if you want to keep the current version instead. |
|
Shouldn't we jump directly to the LTS JDK 11 ? |
|
@cbornet yup, we can consider that. This PR only makes the project buildable/compilable with JDK9. The compiler option is still set to 1.8 in pom.xml. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* update jmockit version * list jvm * test jdk9 in appveyor * use latest version of gradle * update to jdk9 * use openjdk9 * use default java version in appveyor * use jdk8 docker image * consolidate bash, ios pom into parent pom * consolidate circlecii pom into parent pom * remove circleci pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
jmockitinstallation instruction to pom.xml (Ref: http://jmockit.github.io/tutorial/Introduction.html#runningTests)cc @OpenAPITools/generator-core-team