-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust][Server] Upgrade to tokio v1 #11873
Conversation
Looks like some nice simplifications overall and version bumps are always welcome. Good stuff, thanks for your contribution! |
Thanks for the PR. i tested the change locally but got
To repeat the issue, please run Please take a look when you've time. Thank you. |
Thanks for taking a look. I was able to replicate and solve the issue by cross compiling for non-linux target OS. Can you please try again with the latest version? It flew under the radar because I'm testing on a Linux machine and some packages are dependent on the OS. I was able to build by cross compiling for Windows (x86_64-pc-windows-gnu) but I'm unable to test the run executable. So any help would be appreciated. |
All tests passed locally:
|
This PR upgrades rust-server generated code to use tokio v1.
These upgrades are done in combination because they are cross-dependent upon each other, for example hyper depends on tokio 1.0 or higher.
This PR is a spiritual successor to (also based off the branch):
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x