Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][okhttp-gson] Fix bug when specifying grant-type (flow) for OAuth token retry #1183

Merged
merged 3 commits into from
Oct 8, 2018

Conversation

Kiran-Sivakumar
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@bbdouglas @wing328

fix #1181

This implements a solution similar to the one used in the retrofit and retrofit2 libraries. The RetryingOAuth constructor now takes OAuthFlow as input (instead of GrantType) and converts it to the correct GrantType enum value for use in requests.

@Kiran-Sivakumar Kiran-Sivakumar changed the title Fix [Java][okhttp-gson] Fix bug when specifying grant-type (flow) for OAuth token retry Oct 5, 2018
@wing328
Copy link
Member

wing328 commented Oct 6, 2018

cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 added this to the 3.3.1 milestone Oct 6, 2018
@jeff9finger
Copy link
Contributor

LGTM 👍

@wing328 wing328 merged commit 7d58f30 into OpenAPITools:master Oct 8, 2018
@wing328
Copy link
Member

wing328 commented Oct 16, 2018

@Kiran-Sivakumar thanks again for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…th token retry (OpenAPITools#1183)

* Fix bug when specifying grant-type for OAuth token retry

* Update samples

* Update security samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][okhttp-gson] Bug when specifying grant-type (flow) for OAuth token retry
3 participants