Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-spring] Add beanQualifiers switch to populate RestController / Controller annotations with FQCN #11745

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

vlsergey
Copy link
Contributor

@vlsergey vlsergey commented Feb 28, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

P.S.: Yes, i do understand that indented behaviour can be archived using customized templates (and we are using them right now). But i feel that this setting is a solution to quite common problem and may be other Spring-based generators (including Java) shall have this option as well.

@vlsergey vlsergey changed the title Add beanQualifiers option to kotlin-server Add beanQualifiers switch to kotlin-server (to populate RestController / Controller annotations with FQCN) Feb 28, 2022
@vlsergey vlsergey changed the title Add beanQualifiers switch to kotlin-server (to populate RestController / Controller annotations with FQCN) [kotlin-spring] Add beanQualifiers switch to populate RestController / Controller annotations with FQCN Feb 28, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 28, 2022
@wing328
Copy link
Member

wing328 commented Mar 1, 2022

Tested the new option and the result is good.

@wing328 wing328 merged commit 1b6ab63 into OpenAPITools:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants