-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Jackson type info mess fixes (#9441) #11691
Conversation
modules/openapi-generator/src/main/resources/Java/typeInfoAnnotation.mustache
Outdated
Show resolved
Hide resolved
LGTM |
I have no time yet to dig into this - but just based on the title i guess this will affect please keep that in Mind. |
do you want me to somehow respond to this? |
Looks like that PR will change how Given this change only affects annotations, there will be a (small) collision on needing to rectify the annotations on the interfaces. I don't see any major issues with this change going in first given it's isolated to annotations |
Looks good |
You changed a sample configuration which is already removed in master, |
I just wanted to express that there iss another pending PR heavily relying on the JsonTypeInfo to work properly and I want to make sure this does not affect the implementation there. |
modules/openapi-generator/src/main/resources/Java/typeInfoAnnotation.mustache
Outdated
Show resolved
Hide resolved
I've changed the target branch of this PR to master (as it will be released as 6.0.0). Please resolve the merge conflicts and let me know if you need help on that. |
Rebased and squashed. |
This change introduces a change in the OpenAPI specification.
The OpenAPI specification allows for n species to be mapped to 1 component type. This is described in following BUG. This project contains a unit test that reproduces the issue. Can this be reverted/fixed asap? |
Cleanup as mentioned in #9441
Mentioning Java and JavaSpring committee:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608
@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente