-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][RestTemplate] Use class level RestTemplate for uri encoding #11606
[Java][RestTemplate] Use class level RestTemplate for uri encoding #11606
Conversation
…ovided. Otherwise, use the settings from the RestTemplate that was provided.
Run required scripts
@Laurens-W thanks for the PR. Is it correct to say that this change is transparent to the users of the API client? In other words, it's not a breaking change, right? |
In case they are providing their own RestTemplate they will now experience the same behaviour as they did before 5.3.1. So it shouldn't be breaking :) |
👌 thanks for the explanation. PR merged. |
Will this be released in 5.4.1 and when? This is a major issue for us now... Thanks |
It will be included in the v6.0.0 release. You can use the snapshot version of v6.0.0 for the time being (or build the JAR directly from the latest master) |
Hi @wing328 isn't it possible to create a hotfix version for 5.4.x? The encoding of path variables were fully broken in 5.3.1 and 5.4.0. Thanks PS: or maybe some advice how to create an effective workaround? |
My opinion can be biased - the upgrade should be straightforward and there are not many breaking changes in the v6.0.0 release. Please give the snapshot version a try. You may like other improvements as well. |
@wing328 ok understood and thanks. :) |
Moved static logic to initialization method for when no RestTemplate is provided.
Otherwise, use the settings from the RestTemplate that was provided. (Wired by spring)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
Help me on this one: this needs to go into 5.3.2, 5.4.1 and 6.0.x
@lwlee2608 @Zomzog
#11274
#10958