-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: remove special quotation marks from filename generation. #1157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@macjohnny The |
@macjohnny PR is now complete |
@wing328 replaced with |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
…eflect new clean function so that the filename AND imports are added correctly
3f3bdc0
to
00b4eff
Compare
@smasala thanks again for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577 |
@wing328 Thanks! |
…ITools#1157) * remove left|right point double angle quotation marks * move to DefaultCodeGen and update TypeScriptAngularClientCodegen to reflect new clean function so that the filename AND imports are added correctly * rename to a more accurate name :) * shippable fixes * shippable javadoc fix * replaced cleanModelFilename with sanitzeName * remove DefaultCodegen changes
Developed with @tropan
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
(3.3.x),4.0.x
. Default:master
.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09)
Description of the PR
Generics are given double left and right pointing quotation marks in the
JSON
declaration file:MyModel«Set«AnotherType»»
Although the API in (TypeScript) imports the models correctly:
The filename itself still has the special punctuation marks:
This pull request simply removes the special characters from the filename before creation by cleaning the filename string accordingly.
Original Issue:
#1137