-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][vertx] moved HttpStatusException (vertx internal) to HttpException (public) #11550
Conversation
Vertx has moved HttpStatusException (vertx internal) to HttpException (public) https://github.com/vert-x3/wiki/wiki/4.1.0-Deprecations-and-breaking-changes#iovertxextwebhandlerimplhttpstatusexception
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
I got the following when trying to compile the vertx server samples:
Does it work for you locally? |
What are you using to compile locally? I had to update my pom.xml with the new versions of vertx packages (4.2.4)... |
Can you please update the pom.mustache file as part of the PR? |
@wing328 Done... I think this is the correct file. |
I think it should be this one instead: modules/openapi-generator/src/main/resources/JavaVertXWebServer/supportFiles/pom.mustache I updated it locally and confirmed the fix. I'll update it after merging your PR into master UPDATE: done via 4f0c07f |
Vertx has moved HttpStatusException (vertx internal) to HttpException (public)
https://github.com/vert-x3/wiki/wiki/4.1.0-Deprecations-and-breaking-changes#iovertxextwebhandlerimplhttpstatusexception
This is a breaking change in vertx, so this is a priority fix. The changes can be tested by adding the plugin to a Java project and building with vertx-core and vertx-web on the current version, 4.2.4.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
NOTE: A similar PR is at #10299, but author has been inactive and has not addressed issues with the PR mentioned by @wing328 .
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x