Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option to support JDK7 from Java generator and templates #11547

Merged
merged 16 commits into from
Feb 10, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 8, 2022

Default all Java client, server generators to support JDK8 at the minimum

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328 wing328 changed the title Remove java8 from java client generator and templates Remove java8 from Java generator and templates Feb 9, 2022
@wing328 wing328 added Client: Java Enhancement: Code format Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Java labels Feb 9, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 9, 2022
@wing328 wing328 marked this pull request as ready for review February 9, 2022 17:36
@wing328 wing328 changed the title Remove java8 from Java generator and templates Remove the option to support JDK7 from Java generator and templates Feb 9, 2022
@wing328
Copy link
Member Author

wing328 commented Feb 9, 2022

Appveyor failure not related to this change.

@wing328 wing328 merged commit 8455c1c into master Feb 10, 2022
@wing328 wing328 deleted the remove-java8 branch February 10, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Code format Server: Java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants