-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift5][client] try to fix JsonEncondable #11541
[Swift5][client] try to fix JsonEncondable #11541
Conversation
I'm away from my work computer at the moment, so I tried the approach in a playground. It seems to work. What I don't like however is the constant repetition. If you search the history, you will find the code almost exactly as you have implemented it now. |
From my tests, the repetition is necessary to make this work. |
Yep. Agree. I don't mind the repetition if it works, I just think the resulting code is "unattractive". |
An alternative approach would be to enhance the
But this would result in a rather long if statement in the beginning. Matter of taste. |
Yes, that's another option. |
Again, Matter of taste. LGTM. |
@honkmaster thanks for reporting this issue and for validating that it's working |
@4brunu Will this only be released in 6.0.0 or do you think there will be a 5.4.1? |
According to the readme I think it will be available in 6.0.0. |
Hi @4brunu, can this fix be expedited? The project I'm working on is blocked by this bug. Or maybe if there's a suggested workaround - that would be good for now. |
Hi @romanzhukovTB, while there isn't a new release, I suggest that you build the project locally and use openapi through the jar file. |
We reverted back to 5.3.1. Never upgrade a working system again ;). |
I am now also blocked by this issue, and would really appreciate either 6.0.0, or an expedited 5.4.1 if that's at all possible 😬 |
Try to fix #11202 (comment)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)