Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-experimental] fn + method signature improvements #11529

Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Feb 5, 2022

This PR makes improvements that can enable method Schema._validate caching in the future if one wants to implement it.
One would need to:

  • have path_to_item use a generator for the last piece of the path_to_item so duplicate items in the array will have the same hash on their path_to_item
  • have Schema._validate return a dict where the key is empty tuple as path_to_item, and then after that result is returned, append the current path fragment onto all keys in path_to_schemas
  • perhaps pass in a _hash_key=type(arg) argument in the validate method because hash(True) == hash(1) in python

Updates in this PR:

  • InstantiationMetadata changed to ValidationMetadata and only used in validation
  • ValidationMetadata changed to inherit from frozendict, making it immutable
  • InstantiationMetadata no longer passed into __new__ and _from_openapi_data, insetad _configuration is passed in
  • *args becomes arg where possible
  • __new__ and _from_openapi_data signatures kept the same (_configuration passed in) though _from_openapi_data could be rewritten to pass in a parameter named configuration because dicts will always be passed into it as arg. But for __new__, dicts may be passed in as keyword arguments.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether changed the title Feat python exp caches schema validate Feat python-experimental caches Schema._validate Feb 6, 2022
@spacether spacether marked this pull request as draft February 6, 2022 23:39
@spacether spacether changed the title Feat python-experimental caches Schema._validate [python-experimental] fn + method signature improvements Feb 16, 2022
@spacether spacether marked this pull request as ready for review February 16, 2022 03:02
@spacether spacether added this to the 6.0.0 milestone Feb 16, 2022
@spacether spacether force-pushed the feat_python_exp_caches_schema_validate branch 3 times, most recently from 110d457 to 3a8adb5 Compare February 16, 2022 05:21
@spacether spacether force-pushed the feat_python_exp_caches_schema_validate branch from 3a8adb5 to f035b75 Compare February 16, 2022 17:39
@spacether spacether merged commit b165d2d into OpenAPITools:master Feb 16, 2022
@spacether spacether deleted the feat_python_exp_caches_schema_validate branch February 16, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant