Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-experimental] adds missing bases, performance improvements #11517

Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Feb 4, 2022

  • adds missing bases: Int32Base, Int64Base, Float32Base, Float64Base
  • Improves performance by calling cls._get_new_instance_without_conversion rather than _from_openapi_data (which runs validation again)
  • other small performance improvments

Performance improvements investigated per #11496
and comments in that issue show them reducing deserialization tome when ingesting very large responses ~13.8 mB

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@rizwansaeed
Copy link
Contributor

apologies i accidentally approved, feel free to unapprove!

@spacether spacether changed the title [python-experimental] adds missing bases [python-experimental] adds missing bases, performance improvement Feb 4, 2022
@spacether spacether changed the title [python-experimental] adds missing bases, performance improvement [python-experimental] adds missing bases, performance improvements Feb 4, 2022
@spacether spacether added this to the 6.0.0 milestone Feb 4, 2022
@spacether spacether merged commit 6cf4e79 into OpenAPITools:master Feb 4, 2022
@spacether spacether deleted the feat_fixes_bases_python_exp branch February 4, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants