Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cycle detection (#7532) #11500

Merged

Conversation

eak24
Copy link
Contributor

@eak24 eak24 commented Feb 3, 2022

Fix for #7532

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@eak24
Copy link
Contributor Author

eak24 commented Feb 3, 2022

Sorry - this is still a WIP. Looking at the samples

@eak24 eak24 force-pushed the python_recursive_model_cycle_detection branch from a80b699 to 689dd3e Compare February 3, 2022 18:33
@spacether
Copy link
Contributor

@ethan92429 can you update the samples? I need them updated before I can approve and merge it. Thanks!

@eak24
Copy link
Contributor Author

eak24 commented Feb 5, 2022

Done! 😄

@eak24 eak24 force-pushed the python_recursive_model_cycle_detection branch from 594ef81 to 7f610fd Compare February 6, 2022 00:16
@spacether
Copy link
Contributor

Bitrise error looks unrelated

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your PR!

@spacether spacether added this to the 6.0.0 milestone Feb 6, 2022
@spacether spacether merged commit 9f5422d into OpenAPITools:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants