-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cycle detection (#7532) #11500
Merged
spacether
merged 8 commits into
OpenAPITools:master
from
eak24:python_recursive_model_cycle_detection
Feb 6, 2022
Merged
Add cycle detection (#7532) #11500
spacether
merged 8 commits into
OpenAPITools:master
from
eak24:python_recursive_model_cycle_detection
Feb 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry - this is still a WIP. Looking at the samples |
a80b699
to
689dd3e
Compare
spacether
reviewed
Feb 3, 2022
...erator/src/main/java/org/openapitools/codegen/languages/PythonExperimentalClientCodegen.java
Outdated
Show resolved
Hide resolved
spacether
reviewed
Feb 3, 2022
...erator/src/main/java/org/openapitools/codegen/languages/PythonExperimentalClientCodegen.java
Outdated
Show resolved
Hide resolved
spacether
reviewed
Feb 5, 2022
modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientTest.java
Outdated
Show resolved
Hide resolved
@ethan92429 can you update the samples? I need them updated before I can approve and merge it. Thanks! |
Done! 😄 |
594ef81
to
7f610fd
Compare
Bitrise error looks unrelated |
spacether
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for your PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7532
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x