Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements to the MySQL generator #1148

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Minor enhancements to the MySQL generator #1148

merged 2 commits into from
Oct 1, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master (3.3.x), 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • minor code format tweak
  • use .equals instead of ==
  • add window batch file

cc @ybelenko

@wing328 wing328 added this to the 3.3.0 milestone Oct 1, 2018
@wing328 wing328 added Enhancement: General Schema: MySQL Generation of a MySQL Schema labels Oct 1, 2018
@ybelenko ybelenko merged commit 3a5ec0a into master Oct 1, 2018
@wing328 wing328 deleted the mysql_enhance branch October 3, 2018 09:49
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* minor enhancements to the mysql generator

* add ybelenko to the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: General Schema: MySQL Generation of a MySQL Schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants