Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-go-custom-tag to go-server generator #1146

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

andrewkav
Copy link
Contributor

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x ] Filed the PR against the correct branch: master (3.3.x), 4.0.x. Default: master.
  • [ x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The PR adds possibility to include custom tags into generated models
as described in #1145

@antihax @bvwells @grokify

@wing328
Copy link
Member

wing328 commented Oct 11, 2018

@andrewkav as discussed, you may consider using the following to make the line a little bit shorter:

{{#vendorExtensions.x-go-custom-tag}} {{{.}}}{{/vendorExtensions.x-go-custom-tag}}

@andrewkav
Copy link
Contributor Author

@wing328 I've updated the PR. Also added the same for go and go-gin generators to make it consistent.

@wing328 wing328 merged commit ccf9611 into OpenAPITools:master Oct 12, 2018
@wing328
Copy link
Member

wing328 commented Oct 12, 2018

@andrewkav thanks for the enhancement, which has been merged into master.

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09)

@wing328
Copy link
Member

wing328 commented Oct 16, 2018

@andrewkav thanks again for the enhancement, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Add x-go-custom-tag to go-server generator

* update model templates to include x-go-custom-tag
@zh4ngx
Copy link

zh4ngx commented Nov 23, 2021

Question about this - how would one reference the baseName in the yaml definition itself? For purposes of using the property name, or say a camelized version, as part of the custom tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants