-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp-nancyfx] Delete NancyFX #11438
Conversation
merge upstream
merge upstream
@devhl-labs thanks for the PR. I've filed #11454 to start with and we will remove it in the 6.x release. |
Can you give this one a milestone so it is not missed? |
Can you please resolve the merge conflicts when you've time? Upcoming version is 6.0.0 (master) so we can remove this generator. |
@@ -949,7 +949,6 @@ Here is a list of template creators: | |||
* C# ASP.NET Core 3.0: @A-Joshi | |||
* C# APS.NET Core 3.1: @phatcher | |||
* C# Azure functions: @Abrhm7786 | |||
* C# NancyFX: @mstefaniuk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it back after merging it into master as old versions still have this generator available.
NancyFX is archived and the last commit was two years ago.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)