[PHP] Allows setting extra request options via config

[jtreminio]

Allows setting extra headers in request. One use case is setting xdebug cookie for debugging locally.

$config = Configuration::getDefaultConfiguration();

$cookie = GuzzleHttp\Cookie\CookieJar::fromArray([
    'XDEBUG_SESSION' => 'xdebug',
], 'example.com');

$config->setOptions(['cookies' => $cookie]);

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon

[tausa17]

👍 This is something I'm just in the need of and I'm looking forward to it.

[ybelenko]

Basic unit test from me.

vendor/bin/phpunit tests/ConfigurationTest.php

PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

.....                                                               5 / 5 (100%)

Time: 00:00.009, Memory: 6.00 MB

[dkarlovi]

I'm 👎 on this change since it pushes us away from the actual solution we want, which is replaceable HTTP client. We're allowing to pass options to the HTTP client when we could pass the whole HTTP client which is preconfigured with those options, making the code here more complex. It's opposite of IoC, we're binding ourselves more tightly with the client by adding methods to configure it.

[jtreminio]

@dkarlovi Unless I am mistake, the current setup does not permit a user from setting additional options, at all. Seems that allowing a user to do so while decoupling the generated SDK from whatever request library a user wants to use would be a much larger lift than a simple PR. Possibly a BC-break.