Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][okhttp-gson] support multiple file upload #11361

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

lschwahn
Copy link
Contributor

@lschwahn lschwahn commented Jan 20, 2022

fixes #6134

The method buildRequestBodyMultipart in ApiClient.java now recognizes if an input parameter is an instance of List. So it is possible for clients so send multiple files in one request.

Tested by using the generated code in one of our webservices.

Since the existing Pull-Request 8197 seems to be stuck, we made this one to apply the workaround (fixing the generated code) we are using for more than two years now.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The method buildRequestBodyMultipart in ApiClient.java now recognizes if
an input parameter is an instance of List.
@wing328
Copy link
Member

wing328 commented Jan 22, 2022

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328 wing328 added this to the 5.4.0 milestone Jan 24, 2022
@wing328 wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022
@wing328 wing328 merged commit ba04720 into OpenAPITools:master Feb 15, 2022
@wing328 wing328 changed the title fix #6134 for okhttp-gson by considering the input type "List<File>" in ApiClient.mustache [java][okhttp-gson] support multiple files by considering the input type "List<File>" in ApiClient.mustache Feb 15, 2022
@wing328 wing328 changed the title [java][okhttp-gson] support multiple files by considering the input type "List<File>" in ApiClient.mustache [java][okhttp-gson] support multiple file upload by considering the input type "List<File>" in ApiClient.mustache Feb 15, 2022
@wing328 wing328 changed the title [java][okhttp-gson] support multiple file upload by considering the input type "List<File>" in ApiClient.mustache [java][okhttp-gson] support multiple file upload Feb 15, 2022
@wing328
Copy link
Member

wing328 commented Feb 15, 2022

@lschwahn thanks for the PR, which has been merged into the master.

@lschwahn
Copy link
Contributor Author

@wing328 Thanks! I think PR #8197 can be closed, because it fixes the same issue (#6134).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Multipart form with array of files doesn't work
2 participants