Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Scala sttp client generator to sttp3 #11260

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

borissmidt
Copy link
Contributor

@borissmidt borissmidt commented Jan 8, 2022

The sttp generator is out of date by atleast a year, sttp2 has been deprecated and i have updated the generator to now support sttp3.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
  • [ ]
    @chameleon82

@borissmidt
Copy link
Contributor Author

https://github.com/softwaremill/tapir/blob/master/examples/src/main/scala/sttp/tapir/examples/BooksExample.scala
I think it might be even better if we added tapir support instead then it will be really close to 'the universal' scala openApi generator.
I.e. it supports a lot of servers and a lot of clients. So it is like sttp but then reusable for servers.

@wing328
Copy link
Member

wing328 commented Jan 10, 2022

cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

@wing328
Copy link
Member

wing328 commented Jan 10, 2022

FYI. I've changed the target from 5.4.x to master as the master is the upcoming 5.4.0 release.

@borissmidt borissmidt changed the base branch from master to 6.0.x January 11, 2022 09:35
Remove CIRCE_VERSION from generator because it is taken in as a transitive dependency of `  "com.softwaremill.sttp.client3" %% "json4s" % "3.3.18"`
@wing328 wing328 changed the title Upgrade sttp generator to sttp3 Upgrade Scala sttp client generator to sttp3 Feb 7, 2022
@wing328 wing328 changed the base branch from 6.0.x to master February 8, 2022 05:32
@wing328 wing328 merged commit ff30df9 into OpenAPITools:master Feb 8, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 8, 2022
@wing328
Copy link
Member

wing328 commented Feb 8, 2022

cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

@borissmidt
Copy link
Contributor Author

@wing328 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants