Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP-QT-QHTTPENGINE Server] various bug fixes #11177

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

ipittau
Copy link
Contributor

@ipittau ipittau commented Dec 22, 2021

To close #11176

It's related to #10706

PR checklist

  • Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

QT Server was not building and not working because of three issues, fixed in this three commits.

@muttleyxd

@muttleyxd
Copy link
Contributor

Tagging rest of C++ committee

@ravinikam @stkrwork @etherealjoy @MartinDelille

Copy link
Contributor

@muttleyxd muttleyxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the regular expression, rest of the changes look fine.

@wing328 wing328 added this to the 5.4.0 milestone Jan 4, 2022
@wing328 wing328 merged commit 74f39b4 into OpenAPITools:master Jan 4, 2022
@wing328 wing328 changed the title Bugfix of #11176 and related #10706 CPP-QT-QHTTPENGINE Server [CPP-QT-QHTTPENGINE Server] various bug fixes Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CPP-QT-QHTTPENGINE] Code errors generating server with petstore
3 participants