Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat adds content and header properties to CodegenResponse #11046

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Dec 5, 2021

Feat adds content and header properties to CodegenResponse
These are needed

  • to allow responses to work for different response bodies dependent upon content type
  • to allow generated code to surface response header information and send correct accept headers to the server

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft December 5, 2021 23:34
@spacether spacether changed the title Feat adds content and header params to CodegenResponse Feat adds content and header properties to CodegenResponse Dec 5, 2021
@spacether spacether force-pushed the feat_adds_content_and_headerParsm_to_codegenResponse branch from 2bb626a to 8a7b24d Compare December 10, 2021 18:06
@spacether spacether marked this pull request as ready for review December 10, 2021 21:48
@spacether spacether merged commit cee5f75 into OpenAPITools:master Dec 10, 2021
@spacether spacether deleted the feat_adds_content_and_headerParsm_to_codegenResponse branch December 10, 2021 21:49
@spacether
Copy link
Contributor Author

This will be used in #8325

@@ -6609,20 +6648,7 @@ protected String toMediaTypeSchemaName(String contentType) {
for (Entry<String, Header> headerEntry: encHeaders.entrySet()) {
String headerName = headerEntry.getKey();
Header header = ModelUtils.getReferencedHeader(this.openAPI, headerEntry.getValue());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've introduced a tiny bug by not calling this at the other place headerToCodegenParameter is called, therefore referenced headers do not generate correctly.
I'm providing a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants