-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat adds content and header properties to CodegenResponse #11046
Merged
spacether
merged 11 commits into
OpenAPITools:master
from
spacether:feat_adds_content_and_headerParsm_to_codegenResponse
Dec 10, 2021
Merged
Feat adds content and header properties to CodegenResponse #11046
spacether
merged 11 commits into
OpenAPITools:master
from
spacether:feat_adds_content_and_headerParsm_to_codegenResponse
Dec 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
Feat adds content and header params to CodegenResponse
Feat adds content and header properties to CodegenResponse
Dec 5, 2021
spacether
force-pushed
the
feat_adds_content_and_headerParsm_to_codegenResponse
branch
from
December 10, 2021 18:06
2bb626a
to
8a7b24d
Compare
spacether
deleted the
feat_adds_content_and_headerParsm_to_codegenResponse
branch
December 10, 2021 21:49
This will be used in #8325 |
6 tasks
Laurens-W
reviewed
Mar 1, 2022
@@ -6609,20 +6648,7 @@ protected String toMediaTypeSchemaName(String contentType) { | |||
for (Entry<String, Header> headerEntry: encHeaders.entrySet()) { | |||
String headerName = headerEntry.getKey(); | |||
Header header = ModelUtils.getReferencedHeader(this.openAPI, headerEntry.getValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've introduced a tiny bug by not calling this at the other place headerToCodegenParameter is called, therefore referenced headers do not generate correctly.
I'm providing a PR to fix this.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat adds content and header properties to CodegenResponse
These are needed
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x