-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of different types in Elm generator #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add the String.fromBool
alternative
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
@trenneman thanks for the feedback. Please feel free to submit a PR to |
My fix is ready. I had to rebase on #1104, so I'll wait for that one to get merged. |
👌 |
cd15c45
to
b09a2e6
Compare
@wing328 I've updated the PR. Can you verify? |
👍 Let's merge this PR so that we can include the enhancement in the 3.3.0 release. |
* better handling of different types in elm generator * [elm] Fix toString for special cases
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
To fix #1079
cc @trenneman