Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Add option to select/detect content-type. #10978

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

tomplus
Copy link
Member

@tomplus tomplus commented Nov 28, 2021

It's follow up the PR #10686 for python-legacy. It adds an extra argument _content_type to api calls to force a body content-type. It also extends select_header_content_type to return application/json-patch+json and help to override it in more complex scenarios.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

Thank you.

@spacether spacether added this to the 5.3.1 milestone Dec 5, 2021
@spacether
Copy link
Contributor

@tomplus you have a CI error for a python test:
FAILED test/test_fake_api.py::TestFakeApi::test_test_endpoint_enums_length_one
Can you fix it?
Once you fix it I can merge it. Your PR looks good otherwise. Thanks!

@tomplus
Copy link
Member Author

tomplus commented Dec 6, 2021

It looks like all test passed, there is one error reported by ci/bitrise which is probably unrelated to changes.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR; this looks good!

@spacether
Copy link
Contributor

Maven error is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants