[swift5] Refactor encodeToJSON #10961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@4brunu |
4brunu
reviewed
Nov 25, 2021
| @@ -0,0 +1,24 @@ | |||
| set(CPACK_PACKAGE_NAME lib${pkgName}) | |||
There was a problem hiding this comment.
@funzin is this here by accident?
There was a problem hiding this comment.
https://github.com/OpenAPITools/openapi-generator/runs/4324214455?check_suite_focus=tru
Maybe, these files shoud be tracked.
4brunu
reviewed
Nov 25, 2021
Comment on lines
68
to
70
| } | ||
|
|
||
| extension URL: JSONEncodable { | ||
| func encodeToJSON() -> Any { | ||
| return self | ||
| } | ||
| } | ||
|
|
||
| extension UUID: JSONEncodable { | ||
| func encodeToJSON() -> Any { | ||
| return self.uuidString | ||
| } | ||
| }{{/useVapor}}{{#generateModelAdditionalProperties}} | ||
| {{/useVapor}}{{#generateModelAdditionalProperties}} |
This reverts commit cb52547.
|
Hum, it looks like it's a file from the |
|
Add Packing.cmake |
|
Circle CI & BItrise failed but it's not related to this pr |
|
I've restarted https://app.bitrise.io/build/69fe6309-6ba6-4859-bbf0-b3890d47fc53#?tab=log. Let's see how it goes |
wing328
added
Client: Swift
Enhancement: Code Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor encodeToJSON
Some types return
selfonly so we can skip same code using protocol extension method.if type is
UUID,Int16,Int32, we can return self.I checked correct judgment.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x