Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed http errors deserialization #10940

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

dever4eg
Copy link
Contributor

@dever4eg dever4eg commented Nov 23, 2021

I've found this bug in @kubernetes/client-node npm package.

By the way, Here is the issues kubernetes-client/javascript#745
Fixes #2924

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

I've found this bug in @kubernetes/client-node npm package.

By the way, Here is the issue OpenAPITools#2924
@wing328
Copy link
Member

wing328 commented Nov 23, 2021

Thanks for the PR. Can you please follow step 3 to update the samples so that the CI can verify the change?

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@brendandburns
Copy link
Contributor

Thanks @dever4eg this change looks good to me.

Once it merges, I will regenerate the client.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 1314e22 into OpenAPITools:master Nov 24, 2021
@macjohnny macjohnny added this to the 5.3.1 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][typescript-node] The same response type deserialized for all HTTP statuses
4 participants