Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename environment variable for Elm to post-process file #1094

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 24, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Renamed the environment variable to ELM_POST_PROCESS_FILE to make it consistent with other generators.

e.g. export ELM_POST_PROCESS_FILE="/usr/local/bin/elm-format --elm-version=0.18 --yes"
e.g. export ELM_POST_PROCESS_FILE="/usr/local/bin/elm-format --elm-version=0.19 --yes"

@wing328
Copy link
Member Author

wing328 commented Sep 24, 2018

cc @trenneman

@wing328 wing328 added this to the 3.3.0 milestone Sep 24, 2018
@eriktim eriktim merged commit e3b2637 into master Sep 25, 2018
@eriktim eriktim deleted the elm_postprocess_file branch September 25, 2018 07:29
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants