Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio-next] Removes dioLibrary option #10931

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

josh-burton
Copy link
Contributor

As there is no longer a fork of the dio library this option can be removed
#10305

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [x ] File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

@wing328
Copy link
Member

wing328 commented Dec 4, 2021

The Dart 2.1.0 tests failed: https://github.com/OpenAPITools/openapi-generator/runs/4415838129?check_suite_focus=true

Can you please take a look when you've time?

@ahmednfwela
Copy link
Contributor

@wing328 looks like a typical maven timeout

@wing328
Copy link
Member

wing328 commented Dec 4, 2021

Yup, I restarted it but no luck. Will give it another try tomorrow.

@wing328
Copy link
Member

wing328 commented Dec 15, 2021

@josh-burton can you please resolve the merge conflicts when you've time? Then I'll merge. Thanks.

As there is no longer a fork of the dio library this option can be removed
@wing328 wing328 merged commit 6f6d4f8 into OpenAPITools:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants