[C#] Fix issue #1088 with generation of enum classes referenced from other objects #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on properties while processing objects that reference them. Launched the ./bin/csharp-petstore-all.sh script.
|
Sorry for the late response on this… I'm in the middle of purchasing a house and it's taking a lot out of me 💃 I ran this locally and it worked as expected. Seems like something must have been changed in |
|
@rubms thanks for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…renced from other objects (OpenAPITools#1089) * Run ./bin/utils/ensure-up-to-date to re-generate samples run in the CI. * Fixed the OpenAPITools#1088 issue by removing the update of enumeration properties while processing objects that reference them. Launched the ./bin/csharp-petstore-all.sh script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Fixed the #1088 issue. As explained in the suggestion in the issue description, I removed the update of enum properties, in
AbstractCSharpCodeGen.java, for enums referenced from other objects in the OpenAPI specification. The removed update was incorrectly setting theisStringproperties of enum values to false, resulting in an incorrect generation of the enum class, while it is apparently providing no benefit at all.c.c. C# technical committee: @mandrean (2017/08) @jimschubert (2017/09)